ModuleInterface::GetFileExtensions() returns const reference...
... avoiding repeated array allocation
View ArticleDefine class Identifier and template TaggedIdentifier...
... Identifier holds strings used for internal purposes and not shown to users; TaggedIdentifier generates subclasses of Identifier for different purposes, which won't implicitly (that is,...
View ArticleChange CommandManager terminology: "Numeric id" not just "Id" ...
... because I will use CommandId for string identifiers instead, and those are the really persistent identification
View ArticleRemove redundant #include-s from .h files...
Redundant, because transitively implied. But don't do this for inclusions of Audacity.h or Experimental.h.
View ArticleRemove unnecessary #include-s from .cpp files...
... Unnecessary because transitively included. But each .cpp file still includes its own .h file near the top to ensure that it compiles indenendently, even if it is reincluded transitively later.
View ArticleKeyboard prefs accessibility: Narrator can misread the radio buttons.
Problem. If an item in the list is selected, then if a different view by radio button is selected, Narrator reads the selected item rather than the radio button. KeyViewAx::SetCurrentLine(int line)...
View ArticleTrackpanel accessibility: incorrect focus can be read
Problem: If the initial focus is a control in a toolbar, then after applying an effect such as amplify, then the focus is read as being a track, not the control in the toolbar....
View ArticleGrid accessibility: incorrect focus can be read
Problem: this affects NVDA and Narrator, but not Jaws. If a user moves to the Delete button and presses it to delete a label, a label is incorrectly read as the new focus - the focus remains on the...
View ArticleSome naming consistency...
Prefer "MissingAliasFiles" not other permutations of the words
View ArticleMissing alias file tracking out of AudacityApp, into new files...
... which reduces the need for including AudacityApp.h
View ArticleDon't call QuitAudacity directly from src/menus...
... This cuts link dependency on AudacityApp.cpp, and allows the function to be private to that file
View ArticleScriptCommandRelay.cpp is not link dependent on AudacityApp.cpp ...
... Let it send an event to the application instead of calling the handler directly.
View Article